Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump UnicodePlots version #138

Closed
allomulder opened this issue Aug 27, 2022 · 4 comments
Closed

Bump UnicodePlots version #138

allomulder opened this issue Aug 27, 2022 · 4 comments

Comments

@allomulder
Copy link
Contributor

Hello,

UnicodePlots has been updated to 3.0.0 and up for quite a while. Judging by description, it offers quite a performance improvement. Maybe consider bumping compat version?

@Datseris
Copy link
Member

Datseris commented Aug 28, 2022

Sure, wanna do a PR that increases this version? (and in the same PR test that the showing of recurrence plots still works?)

@allomulder
Copy link
Contributor Author

@Datseris I'm a bit of a Julia newbie and just trying out things for now, so it might take a while for me :D But yes, I'd like to try, if noone beats me to it.

@Datseris
Copy link
Member

Don't worry. It isn't very difficult. First, do dev RecurrenceAnalysis. It will make a local copy of the repo for you. Go into it, in Project.toml, and increase the version that bounds UnicodePlots. Then, restart Julia, update (so that the new version of Unicode Plots is downloaded), and just using RecurrenceAnalysis and make a trivial RR matrix. If it shows correctly in e.g., VSCode, we're good to go, and you can push your local code to your fork on GitHub and open a PR here!

@allomulder
Copy link
Contributor Author

@Datseris seems like I did that and the world hasn't collapsed immediately. Guess that's a good result :D

Thank you for you help and check out PR #139, please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants