Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump UnicodePlots to version 3 #139

Merged
merged 2 commits into from
Aug 29, 2022
Merged

Bump UnicodePlots to version 3 #139

merged 2 commits into from
Aug 29, 2022

Conversation

allomulder
Copy link
Contributor

Hello,

Just added version 3 of UnicodePlots to Project, and it seems to be working the same as before. I tested it on the example from DynamicalSystems documentation.

Attaching screenshots for proof:

  1. Code output from my main environment containing current stable versions of DynamicalSystems and RecurrenceAnalysis:
    image
  2. Code output from the environment with bumped UnicodePlots version:
    image
  3. Project status of that environment:
    image

@Datseris
Copy link
Member

Thanks, seems LGTM to me! Can you also please bump minor version (second number) of the RecurrenceAnalysis version so that I tag a release immediatelly after merging your PR?

@allomulder
Copy link
Contributor Author

@Datseris done, bumped it to 1.9.0

@Datseris
Copy link
Member

@allomulder it seems there was some sorts of f**k-up in my commits to master and now tests do not pass. I'll push a fix to the tests in this PR and merge, but I can't promise when this will happen exactly.

@Datseris
Copy link
Member

actually I'm merging this in now, as your changes are valid. I'd still have to fix test before I release a new version though!

@Datseris Datseris merged commit 52429f3 into JuliaDynamics:master Aug 29, 2022
@allomulder
Copy link
Contributor Author

@Datseris That's okay, thank you! I was a bit surprised actually, when I cloned this repo and VSCode showed me about 100+ messages that something is wrong. Hopefully it won't be too hard to fix it! If I find the time, maybe I'll also look into this and try to test it, but can't promise it though.

If I do, however, I'll make another PR and notify you.

@vancleve
Copy link

any chance this could make it into a new release sometime soon?

@Datseris
Copy link
Member

Please use master branch until then, we need a bit more time to make any release. add RecurrenceAnalysis#master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants