origin and spacing not taken into account when plotting

[briochemc]

It seems that origin and spacing are not taken into account when plotting things onto grids.

(not-so-M)WE:

using Plots
origin = (-100.0, -200.0)
spacing = (5.0, 5.0)
X = origin[1]:100
Y = origin[2]:200
Z = [10sin(x/10) + y for x in X, y in Y]
plt1 = heatmap(X,Y,Z')
using GeoStats
Ω = RegularGridData{Float64}(OrderedDict(:Z=>Z))
RegularGridData(OrderedDict(:Z=>Z), origin .+ 1000, spacing)
plt2 = plot(Ω)
plot(plt1, plt2, layout=(2,1))

I was expecting the bottom plot to show the shifted origin and (5.0,5.0) spacing, but it does not?

[juliohm]

I recall this wasn't possible with Plots.jl + GR.jl recipes back then, but perhaps the recipe system got updated. I am not sure. Do you think you could try fix the plot recipe here? https://github.com/JuliaEarth/GeoStatsBase.jl/blob/master/src/plotrecipes/domains/regular_grid.jl#L5-L24

Instead of returning the 2D matrix, we could return:

X = coordinates(domain)
...
elseif N == 2
...
X[1,:], X[2,:], Z

The actual plan is to move from Plots.jl recipes to Makie.jl recipes in the next milestone.

[juliohm]

Fixed on master. Thanks for catching it 💯