-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Covariance methods #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the issue. Besides the small changes regarding internal fields, we also need basic tests for coverage purposes.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Is there a public API for the (cov::Covariance)(x₁, x₂) = sill(cov.γ) - cov.γ(x₁, x₂) and followed along. I could add a |
What I meant is that you accessed gamma.ball, the internal field of gamma.
Em dom., 24 de mar. de 2024, 23:09, Mark Baum ***@***.***>
escreveu:
… Is there a public API for the γ field? I considered this but noticed
(cov::Covariance)(x₁, x₂) = sill(cov.γ) - cov.γ(x₁, x₂)
and followed along.
I could add a variogram(cov::Covariance) = cov.γ function.
—
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZQW3IFJCIJC5SQHH3372LYZ6BMJAVCNFSM6AAAAABFF5C7SKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJXGA4DINZRHE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @markmbaum , attached a last round of review for this one.
Co-authored-by: Júlio Hoffimann <julio.hoffimann@gmail.com>
I think it should be all set now. All tests passed locally. |
Thank you @markmbaum ! Releasing a patch for this now... |
I added methods for
Covariance
types that weren't initially implemented:isstationary
isisotropic
sill
nugget
metricball
Base.range
scale
All of these methods pass the call to the underlying variogram, so I didn't add any new tests.
I did confirm that the example in the linked issue now works:
closes JuliaEarth/GeoStats.jl#404