Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Method of looking up stdlibs fails on Julia 1.8 #41

Open
danielmatz opened this issue Dec 20, 2022 · 0 comments · May be fixed by #43
Open

Method of looking up stdlibs fails on Julia 1.8 #41

danielmatz opened this issue Dec 20, 2022 · 0 comments · May be fixed by #43

Comments

@danielmatz
Copy link

There's a test failure for PkgDeps when using Julia 1.8. It seems that the Pkg API changed a little bit, and the method used here to get a list of stdlib names no longer works.

In Julia 1.7, I get:

julia> Pkg.Types.stdlibs()
Dict{Base.UUID, String} with 58 entries:
  UUID("efcefdf7-47ab-520b-bdef-62a2eaa19f15") => "PCRE2_jll"
  UUID("745a5e78-f969-53e9-954f-d19f2f74f4e3") => "LibUnwind_jll"
# etc.

And in Julia 1.8, I get:

Dict{Base.UUID, Tuple{String, Union{Nothing, VersionNumber}}} with 58 entries:
  UUID("efcefdf7-47ab-520b-bdef… => ("PCRE2_jll", v"10.40.0+0")
  UUID("745a5e78-f969-53e9-954f… => ("LibUnwind_jll", v"1.5.0+0")
# etc.
danielmatz added a commit to danielmatz/PkgDeps.jl that referenced this issue Dec 20, 2022
@danielmatz
Fix lookup of stdlibs on Julia v1.8
2ce35a2 
With Julia v1.8, there were Pkg API changes that caused this package
to break. In particular, our method of determining whether a package
is part of the standard library now fails.

With older versions of Julia, `Pkg.Types.stdlibs()` returns a
dictionary mapping `UUID`s to `String`s, which are just the package
names. As of Julia v1.8, `Pkg.Types.stdlibs()` returns a dictionary
mapping `UUID`s to `Tuple{String, Union{Nothing, VersionNumber}}`.

This commit reworks the dictionary returned by `Pkg.Types.stdlibs()`
for Julia v1.8 and later, so that the rest of the existing code in
this package will work without modification.

Fixes JuliaEcosystem#41.
@danielmatz danielmatz linked a pull request Dec 20, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix lookup of stdlibs on Julia v1.8 danielmatz/PkgDeps.jl
1 participant
@danielmatz