Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip] improve coverage #8

Merged
merged 6 commits into from Jul 18, 2017
Merged

[wip] improve coverage #8

merged 6 commits into from Jul 18, 2017

Conversation

ahojukka5
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Jul 18, 2017 •
edited

Coverage Status

Coverage increased (+0.7%) to 94.118% when pulling 238db78 on fix/coverage into 3d25c28 on master.

@coveralls
Copy link

coveralls commented Jul 18, 2017 •
edited

Coverage Status

Coverage increased (+2.3%) to 95.745% when pulling 0c4ffef on fix/coverage into 3d25c28 on master.

ovainola
ovainola reviewed Jul 18, 2017
View reviewed changes
src/parse_mesh.jl Outdated
@@ -178,10 +171,12 @@ function parse_section(model, lines, key, idx_start, idx_end, ::Type{Val{:SURFAC
for line in lines[idx_start + 1: idx_end]
empty_or_comment_line(line) && continue
m = match(r"(?P<element_id>\d+),.*(?P<element_side>S\d+).*", line)
#=
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is not needed, just delete the comment section?

@coveralls
Copy link

coveralls commented Jul 18, 2017 •
edited

Coverage Status

Coverage increased (+4.3%) to 97.756% when pulling 41c3440 on fix/coverage into 3d25c28 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+4.02%) to 97.518% when pulling 0e0f5d1 on fix/coverage into 64c4086 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+4.02%) to 97.518% when pulling 0e0f5d1 on fix/coverage into 64c4086 on master.

ovainola
ovainola reviewed Jul 18, 2017
View reviewed changes
Copy link
Collaborator

@ovainola ovainola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before mergin to master, remember to remove [wip] from commit title

@coveralls
Copy link

Coverage Status

Coverage increased (+4.02%) to 97.518% when pulling 0e0f5d1 on fix/coverage into 64c4086 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+4.02%) to 97.518% when pulling 0e0f5d1 on fix/coverage into 64c4086 on master.

@coveralls
Copy link

coveralls commented Jul 18, 2017 •
edited

Coverage Status

Coverage increased (+6.2%) to 99.647% when pulling 1248725 on fix/coverage into 64c4086 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+5.5%) to 100.0% when pulling a7f8650 on fix/coverage into 6c26d8e on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+5.5%) to 100.0% when pulling a7f8650 on fix/coverage into 6c26d8e on master.

@ahojukka5 ahojukka5 merged commit fd6679f into master Jul 18, 2017
ahojukka5 added a commit that referenced this pull request Jul 18, 2017
@ahojukka5
Improve coverage (#8)
cf4f37f 
* add more tests, coverage 100 % now
* closes #6
@ahojukka5 ahojukka5 deleted the fix/coverage branch July 19, 2017 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ovainola ovainola ovainola left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ahojukka5 @coveralls @tkelman @ovainola