New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Featuring guyan reduction #6
Conversation
Files inside |
Checkout master and rebase to get newest |
|
To remove unnecessary files:
|
After removing unwanted files and commiting changes to repository, you may want to rebase changes, i.e. squash commits to single one, see https://www.google.fi/search?q=git+squash Read this: https://github.com/JuliaLang/julia/blob/master/CONTRIBUTING.md |
d67e22b
to
9791607
Compare
Could you squash these commits also? |
Coverage remained the same at 100.0% when pulling 9b554016e50f617d59ea09e53942925dbadc2cd4 on featuring_guyan_reduction into 80b4f79 on master. |
Notice that I have merged conflicts already, so you may need to pull changes to local computer before squashing. |
src/guyan_reduction.jl
Outdated
# This file is a part of JuliaFEM. | ||
# License is MIT: see https://github.com/JuliaFEM/ModelReduction.jl/blob/master/LICENSE | ||
|
||
function guyan_reduction(K, m, s) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add docstring, describe function arguments
test/test_guyan_reduction.jl
Outdated
|
||
using ModelReduction | ||
|
||
K = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to add data related to test inside that testset
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small changes to code
test/test_guyan_reduction.jl
Outdated
|
||
@testset "Perform Guyan Reduction" begin | ||
expected = | ||
[0.25 -0.25; -0.25 0.25] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To same line
test/test_guyan_reduction.jl
Outdated
expected = | ||
[0.25 -0.25; -0.25 0.25] | ||
result = ModelReduction.guyan_reduction(K, m, s) | ||
@test result ≈ expected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use isapprox instead
20553a2
to
9b3a58f
Compare
f270024
to
cc00572
Compare
cc00572
to
a5a4d60
Compare
No description provided.