Fix functionality broken by 0.6 subtyping changes #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this. Good to go? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the functionality broken by 0.6 subtyping and macro hygiene changes, such that the package core functionality no longer freezes Julia. (
It is possible that the breakage is due to a Julia bug, see JuliaLang/julia#20130, but this can be worked around.This breakage is actually due to fixing behaviour that was incorrect before, and Currencies was depending on.) Tests are still failing but for unrelated reasons.Fixes #63
cc @tkelman
Since this issue is causing problems with PackageEvaluator, I will merge and tag in 24 hours if there are no objections.