Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct floating point trunc, floor, ceil #83

Merged
merged 4 commits into from
May 14, 2017
Merged

Conversation

TotalVerb
Copy link
Member

@omus, after a little thought (and with help from @musm) I've decided that this is a more complete fix for the inaccurate floats. What this is doing behind the scenes is using double double arithmetic to work around the loss of precision from the multiplication.

I've modified the tests slightly but they should be a superset of the ones that you added (Thanks for that!).

@coveralls
Copy link

coveralls commented May 14, 2017

Coverage Status

Coverage decreased (-0.2%) to 96.209% when pulling d665598 on fw/accurate-trunc into 0e56bea on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 96.209% when pulling d665598 on fw/accurate-trunc into 0e56bea on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 96.209% when pulling d665598 on fw/accurate-trunc into 0e56bea on master.

@coveralls
Copy link

coveralls commented May 14, 2017

Coverage Status

Coverage decreased (-0.2%) to 96.209% when pulling d665598 on fw/accurate-trunc into 0e56bea on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 96.209% when pulling d665598 on fw/accurate-trunc into 0e56bea on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 96.209% when pulling d665598 on fw/accurate-trunc into 0e56bea on master.

@codecov
Copy link

codecov bot commented May 14, 2017

Codecov Report

Merging #83 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
+ Coverage    96.4%   96.44%   +0.04%     
==========================================
  Files          17       17              
  Lines         417      422       +5     
==========================================
+ Hits          402      407       +5     
  Misses         15       15
Impacted Files Coverage Δ
src/FixedPointDecimals/FixedPointDecimals.jl 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e56bea...f976eba. Read the comment docs.

@coveralls
Copy link

coveralls commented May 14, 2017

Coverage Status

Coverage decreased (-0.2%) to 96.209% when pulling f0bca22 on fw/accurate-trunc into 0e56bea on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 96.209% when pulling f0bca22 on fw/accurate-trunc into 0e56bea on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 96.209% when pulling f0bca22 on fw/accurate-trunc into 0e56bea on master.

@coveralls
Copy link

coveralls commented May 14, 2017

Coverage Status

Coverage increased (+0.04%) to 96.445% when pulling f976eba on fw/accurate-trunc into 0e56bea on master.

4 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 96.445% when pulling f976eba on fw/accurate-trunc into 0e56bea on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 96.445% when pulling f976eba on fw/accurate-trunc into 0e56bea on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 96.445% when pulling f976eba on fw/accurate-trunc into 0e56bea on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 96.445% when pulling f976eba on fw/accurate-trunc into 0e56bea on master.

@TotalVerb TotalVerb merged commit ae9fb31 into master May 14, 2017
@EricForgy EricForgy deleted the fw/accurate-trunc branch February 25, 2019 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants