-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update travis, appveyor #93
Conversation
Codecov Report
@@ Coverage Diff @@
## master #93 +/- ##
========================================
Coverage ? 97.8%
========================================
Files ? 16
Lines ? 273
Branches ? 0
========================================
Hits ? 267
Misses ? 6
Partials ? 0 Continue to review full report at Codecov.
|
I might be totally wrong here, but:
Just some thoughts, again, I might be way off here. |
Thanks, I appreciate the help! This package is pretty old (from the 0.4 days) and we've been lagging behind on the best practices for our travis and appveyor files. Let's see if this will work. |
It worked! |
There is actually still a problem with the Travis code coverage after_success code which does not affect success of the test. I will try to copy over a .travis.yml that other projects are using which has working coverage. |
I mentioned skeleton.jl, he has a good travis template there: https://github.com/tpapp/skeleton.jl/blob/master/template/.travis.yml |
You might want to consider capping Documenter here as well. See this thread on Discourse for more information. |
Hope its alright. I merged this PR into #97 . If tests pass, I'll merge that one and close this one if that's alright. |
Closed via #97 |
Let's see if tests pass...