Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update travis, appveyor #93

Closed
wants to merge 4 commits into from
Closed

Update travis, appveyor #93

wants to merge 4 commits into from

Conversation

TotalVerb
Copy link
Member

Let's see if tests pass...

@codecov
Copy link

codecov bot commented Oct 16, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@c96644b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master     #93   +/-   ##
========================================
  Coverage          ?   97.8%           
========================================
  Files             ?      16           
  Lines             ?     273           
  Branches          ?       0           
========================================
  Hits              ?     267           
  Misses            ?       6           
  Partials          ?       0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c96644b...1404408. Read the comment docs.

@yakir12
Copy link

yakir12 commented Oct 17, 2018

I might be totally wrong here, but:

  1. seems like you didn't include v1 in appveyor, only nightly, which failed on versioninfo, not sure why, but it's ok to let nightly fail, so you could just allow fails on nightly
  2. why do you have versioninfo in there anyways? It doesn't seem to do anything.
  3. finally, I recommend using this template for appveyor, then you know you got it right. Better yet, you could use skeleton.

Just some thoughts, again, I might be way off here.

@TotalVerb
Copy link
Member Author

Thanks, I appreciate the help! This package is pretty old (from the 0.4 days) and we've been lagging behind on the best practices for our travis and appveyor files. Let's see if this will work.

@yakir12
Copy link

yakir12 commented Oct 17, 2018

It worked!

@TotalVerb
Copy link
Member Author

There is actually still a problem with the Travis code coverage after_success code which does not affect success of the test. I will try to copy over a .travis.yml that other projects are using which has working coverage.

@yakir12
Copy link

yakir12 commented Oct 18, 2018

I mentioned skeleton.jl, he has a good travis template there: https://github.com/tpapp/skeleton.jl/blob/master/template/.travis.yml

@mortenpi
Copy link

You might want to consider capping Documenter here as well. See this thread on Discourse for more information.

@EricForgy EricForgy mentioned this pull request Jan 12, 2019
@EricForgy
Copy link
Member

Hope its alright. I merged this PR into #97 . If tests pass, I'll merge that one and close this one if that's alright.

@EricForgy
Copy link
Member

Closed via #97

@EricForgy EricForgy closed this Jan 17, 2019
@EricForgy EricForgy deleted the fw/travis branch February 25, 2019 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants