Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autodiff fallback for gradient computation using Zygote #52

Merged
merged 4 commits into from
Oct 20, 2021

Conversation

lostella
Copy link
Member

...plus other minor changes.

@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #52 (1c89460) into master (ab341f2) will decrease coverage by 0.40%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
- Coverage   88.79%   88.38%   -0.41%     
==========================================
  Files          20       20              
  Lines         794      801       +7     
==========================================
+ Hits          705      708       +3     
- Misses         89       93       +4     
Impacted Files Coverage Δ
src/ProximalAlgorithms.jl 100.00% <ø> (ø)
src/utilities/ad.jl 100.00% <100.00%> (ø)
src/utilities/conjugate.jl 100.00% <100.00%> (ø)
src/algorithms/drls.jl 91.22% <0.00%> (-5.27%) ⬇️
src/utilities/iteration_tools.jl 82.43% <0.00%> (-1.36%) ⬇️
src/algorithms/primal_dual.jl 63.55% <0.00%> (-0.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab341f2...1c89460. Read the comment docs.

@lostella
Copy link
Member Author

lostella commented Oct 19, 2021

I’m not sure why exactly Julia 1.3 cannot resolve the version of AbstractOperators (test dependency), but I suppose we can avoid using it at all in favor of the autodiff fallback :-)

cc @nantonel

@nantonel
Copy link
Collaborator

Nice!

Well we could merge it and remove that AbstractOperators dependency later on. What do you think?
I don't think many people is running 1.3... Perhaps we can drop that too for a green badge?

@lostella lostella merged commit 96fd0c2 into JuliaFirstOrder:master Oct 20, 2021
@lostella lostella deleted the add-ad-fallback branch October 20, 2021 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants