Run tests on Julia 1.6 and 1.7 #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
==========================================
+ Coverage 88.99% 89.03% +0.03%
==========================================
Files 21 20 -1
Lines 854 857 +3
==========================================
+ Hits 760 763 +3
Misses 94 94
Continue to review full report at Codecov.
|
lostella
commented
Dec 9, 2021
| @@ -53,7 +53,7 @@ Base.@kwdef mutable struct DRLSState{R,Tx,TH} | |||
| res::Tx | |||
| res_prev::Tx = similar(x) | |||
| xbar::Tx | |||
| xbar_prev::Tx = similar(x) | |||
| xbar_prev::Tx = copy(xbar) | |||
There was a problem hiding this comment.
@nantonel This was one of the bugs you were afraid of, tests caught it (but didn't before!) 🙂
There was a problem hiding this comment.
eheh! told you similar can be dangerous!
nantonel
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.