Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typing issues in Nesterov and Broyden acceleration #73

Merged
merged 3 commits into from
Feb 27, 2022

Conversation

lostella
Copy link
Member

@lostella lostella commented Feb 27, 2022

Fix the following:

  • Wrong method for iteration protocol is implemented on Nesterov sequences to get the eltype
  • BroydenOperator is unnecessarily mutable, and typed in an overly complex and incomplete manner

Bump bugfix version number.

@codecov
Copy link

codecov bot commented Feb 27, 2022

Codecov Report

Merging #73 (1de0e45) into master (9fe03c1) will increase coverage by 0.26%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
+ Coverage   88.67%   88.93%   +0.26%     
==========================================
  Files          21       21              
  Lines         883      886       +3     
==========================================
+ Hits          783      788       +5     
+ Misses        100       98       -2     
Impacted Files Coverage Δ
src/accel/broyden.jl 100.00% <100.00%> (ø)
src/accel/nesterov.jl 87.87% <100.00%> (+6.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fe03c1...1de0e45. Read the comment docs.

@lostella lostella merged commit e7ce82e into JuliaFirstOrder:master Feb 27, 2022
@lostella lostella deleted the fix-nesterov-broyden branch February 27, 2022 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant