Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type issues #141

Merged
merged 2 commits into from
Mar 21, 2022
Merged

Conversation

lostella
Copy link
Member

This fixes some type issues spotted with the aid of JET.jl (I hope I interpreted the complaints right).

This should bring some performance improvement in iterative cases where CG is used to compute prox.

@codecov
Copy link

codecov bot commented Mar 20, 2022

Codecov Report

Merging #141 (838d991) into master (04204f7) will decrease coverage by 0.07%.
The diff coverage is 95.23%.

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
- Coverage   95.88%   95.80%   -0.08%     
==========================================
  Files          79       79              
  Lines        2382     2386       +4     
==========================================
+ Hits         2284     2286       +2     
- Misses         98      100       +2     
Impacted Files Coverage Δ
src/functions/indGraphSkinny.jl 100.00% <ø> (ø)
src/functions/leastSquaresDirect.jl 93.42% <0.00%> (ø)
src/calculus/tilt.jl 100.00% <100.00%> (ø)
src/functions/indPSD.jl 100.00% <100.00%> (ø)
src/functions/leastSquaresIterative.jl 97.77% <100.00%> (ø)
src/utilities/linops.jl 68.08% <100.00%> (-1.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04204f7...838d991. Read the comment docs.

@lostella
Copy link
Member Author

This should bring some performance improvement in iterative cases where CG is used to compute prox.

Indeed:

  ["LeastSquares", ("ComplexF64", "(11, 5)", 0, 1)] 0.93 (5%) ✅  0.95 (1%) ✅
  ["LeastSquares", ("ComplexF64", "(11, 5)", 1, 1)] 0.93 (5%) ✅  0.87 (1%) ✅
  ["LeastSquares", ("ComplexF64", "(5, 11)", 0, 1)]   0.95 (5%)  0.96 (1%) ✅
  ["LeastSquares", ("ComplexF64", "(5, 11)", 1, 1)] 0.94 (5%) ✅  0.87 (1%) ✅
     ["LeastSquares", ("Float64", "(11, 5)", 0, 1)] 0.92 (5%) ✅  0.96 (1%) ✅
     ["LeastSquares", ("Float64", "(11, 5)", 1, 1)] 0.93 (5%) ✅  0.87 (1%) ✅
     ["LeastSquares", ("Float64", "(5, 11)", 0, 1)] 0.94 (5%) ✅  0.97 (1%) ✅
     ["LeastSquares", ("Float64", "(5, 11)", 1, 1)] 0.94 (5%) ✅  0.87 (1%) ✅

@lostella lostella merged commit 2dd41c6 into JuliaFirstOrder:master Mar 21, 2022
@lostella lostella deleted the fix-jet-complaints branch March 21, 2022 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant