Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to ProximalAlgorithms v0.5 #40

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

dhanak
Copy link
Contributor

@dhanak dhanak commented Jun 22, 2023

  • drop support for ForwardBackward optimizer;
  • add support for PANOCplus;
  • make PANOCplus the default optimizer;
  • stabilize unstable unit test.

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #40 (e2e8a00) into master (d3a2f64) will increase coverage by 0.37%.
The diff coverage is 92.00%.

❗ Current head e2e8a00 differs from pull request most recent head 50f844b. Consider uploading reports for the commit 50f844b to get more accurate results

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
+ Coverage   91.87%   92.24%   +0.37%     
==========================================
  Files          16       17       +1     
  Lines         480      503      +23     
==========================================
+ Hits          441      464      +23     
  Misses         39       39              
Impacted Files Coverage Δ
src/StructuredOptimization.jl 100.00% <ø> (ø)
src/arraypartition.jl 62.50% <ø> (ø)
src/syntax/terms/proximalOperators_bind.jl 92.42% <88.00%> (+0.11%) ⬆️
src/solvers/minimize.jl 94.73% <92.30%> (ø)
src/calculus/precomposeNonlinear.jl 88.88% <100.00%> (+0.42%) ⬆️
src/solvers/build_solve.jl 95.45% <100.00%> (ø)
src/syntax/terms/term.jl 77.77% <100.00%> (ø)

... and 5 files with indirect coverage changes

Copy link
Member

@lostella lostella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dhanak! I guess we can bump the dependency on AbstractOperators too.

I’m not entirely sure why we need to drop support for ForwardBackward?

Project.toml Outdated
@@ -13,10 +13,10 @@ RecursiveArrayTools = "731186ca-8d62-57ce-b412-fbd966d074cd"

[compat]
AbstractOperators = "0.1 - 0.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
AbstractOperators = "0.1 - 0.2"
AbstractOperators = "0.3"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. In fact, I requested a version bump on AbstractOperators, I'm glad it went through so quickly.

@dhanak
Copy link
Contributor Author

dhanak commented Jun 26, 2023

I’m not entirely sure why we need to drop support for ForwardBackward?

ProximalAlgorithms dropped support for an external A matrix, ForwardBackward is now just f(x) + g(x), so the transformations in StructuredOptimzation don't work with FB anymore. There are the DouglasRatchford and the DRLS solvers, which could be added to the suite, though.

1 similar comment
@dhanak
Copy link
Contributor Author

dhanak commented Jun 26, 2023

I’m not entirely sure why we need to drop support for ForwardBackward?

ProximalAlgorithms dropped support for an external A matrix, ForwardBackward is now just f(x) + g(x), so the transformations in StructuredOptimzation don't work with FB anymore. There are the DouglasRatchford and the DRLS solvers, which could be added to the suite, though.

@dhanak
Copy link
Contributor Author

dhanak commented Jun 26, 2023

Please note that I won't be available in the next 10 days or so.

@dhanak dhanak requested a review from lostella June 26, 2023 09:56
* drop support for ForwardBackward optimizer;
* add support for PANOCplus;
* stabilize unstable unit test;
* bump upper version limit on DSP.
Copy link
Member

@lostella lostella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dhanak!

@lostella lostella merged commit f0a25b0 into JuliaFirstOrder:master Jun 30, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants