Improve append!!(::SVector, ::SingletonVector) (#174)

JuliaFolds · Jul 1, 2020 · d2d83d2 · d2d83d2
1 parent 9aa6d53
commit d2d83d2
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/src/NoBang/base.jl b/src/NoBang/base.jl
@@ -44,14 +44,12 @@ append(xs::AbstractVector, ys::AbstractVector) =
         vcat(xs, ys)
     elseif length(ys) == 0
         xs
-    #=
-    elseif length(ys) == 1
-        push(xs, ys[1])
-    =#
     else
         # Not so robust:
         # append!!(push(xs, ys[1]), @view ys[2:end])
-        foldl(push!!, (@view ys[2:end]), init=push(xs, ys[1]))
+        zs = push(xs, ys[1])
+        length(ys) == 1 && return zs
+        foldl(push!!, (@view ys[2:end]), init = zs)
     end
 
 append(xs::ImmutableContainer, ys) = push(xs, ys...)