Avoid unintended materialization in @!

JuliaFolds · Aug 28, 2019 · e33e260 · e33e260
1 parent 6b5fc66
commit e33e260
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/src/macro.jl b/src/macro.jl
@@ -21,7 +21,7 @@ macro !(expr)
             lhs, rhs = x.args
             return :($lhs = $materialize!!(
                 $Base.@isdefined($lhs) ? $lhs : $(Undefined()),
-                $rhs,
+                $air.($rhs),
             ))
         end
         return x
@@ -39,3 +39,10 @@ function undotoperator(x::Symbol)
     Base.isoperator(op) || return nothing
     return op
 end
+
+function air end
+struct Aired{T}
+    value::T
+end
+@inline Broadcast.broadcasted(::typeof(air), x) = Aired(x)
+@inline Broadcast.materialize(x::Aired) = x.value
diff --git a/test/test_materialize.jl b/test/test_materialize.jl
@@ -1,13 +1,7 @@
 module TestMaterialize
 
 include("preamble.jl")
-
-function air end
-struct Aired{T}
-    value::T
-end
-@inline Broadcast.broadcasted(::typeof(air), x) = Aired(x)
-@inline Broadcast.materialize(x::Aired) = x.value
+using BangBang: air
 
 @testset begin
     @test materialize!!(nothing, air.([0, 1] .+ 2))::Vector{Int} == [2, 3]