Make append!! work with immutable containers in NoBang

[tkf]

No description provided.

[codecov-commenter]

Codecov Report

Merging #145 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
+ Coverage   92.09%   92.11%   +0.01%     
==========================================
  Files          21       21              
  Lines         443      444       +1     
==========================================
+ Hits          408      409       +1     
  Misses         35       35              

Impacted Files	Coverage Δ
src/BangBang.jl	100.00% <ø> (ø)
src/NoBang/singletoncontainers.jl	100.00% <100.00%> (ø)
src/core.jl	82.35% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da093a1...890bbab. Read the comment docs.

[github-actions]

Benchmark result

Judge result

Benchmark Report for /home/runner/work/BangBang.jl/BangBang.jl

Job Properties

• Time of benchmarks:
  • Target: 22 May 2020 - 20:55
  • Baseline: 22 May 2020 - 20:56
• Package commits:
  • Target: e0c500
  • Baseline: da093a
• Julia commits:
  • Target: 381693
  • Baseline: 381693
• Julia command flags:
  • Target: None
  • Baseline: None
• Environment variables:
  • Target: None
  • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID	time ratio	memory ratio
["append", "append!!(::SVector, ::SingletonVector)"]	0.06 (5%) ✅	0.09 (1%) ✅
["collectors", ":comp => \"filter\"", ":impl => \"base\""]	1.19 (5%) ❌	1.00 (1%)
["collectors", ":comp => \"filter\"", ":impl => \"nonexpanding\""]	0.80 (5%) ✅	1.00 (1%)
["collectors", ":comp => \"map\"", ":impl => \"coll\""]	0.94 (5%) ✅	1.00 (1%)
["collectors", ":comp => \"map\"", ":impl => \"safe_coll\""]	0.89 (5%) ✅	1.00 (1%)
["dataframes", "Categorical"]	0.88 (5%) ✅	1.00 (1%)
["dataframes", "Int-Int"]	1.08 (5%) ❌	1.00 (1%)
["dataframes", "Missing-String"]	1.54 (5%) ❌	1.00 (1%)
["dataframes", "String-String"]	1.52 (5%) ❌	1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

• ["append"]
• ["collectors", ":comp => \"filter\""]
• ["collectors", ":comp => \"map\""]
• ["dataframes"]

Julia versioninfo

Target

Julia Version 1.4.1
Commit 381693d3df* (2020-04-14 17:20 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.4 LTS
  uname: Linux 5.3.0-1020-azure #21~18.04.1-Ubuntu SMP Wed Apr 15 09:35:56 UTC 2020 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz: 
              speed         user         nice          sys         idle          irq
       #1  2095 MHz      17657 s          0 s       1549 s       9573 s          0 s
       #2  2095 MHz       7960 s          0 s       1323 s      19359 s          0 s
       
  Memory: 6.764888763427734 GB (3588.125 MB free)
  Uptime: 301.0 sec
  Load Avg:  1.0556640625  0.78076171875  0.36474609375
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-8.0.1 (ORCJIT, skylake)

Baseline

Julia Version 1.4.1
Commit 381693d3df* (2020-04-14 17:20 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.4 LTS
  uname: Linux 5.3.0-1020-azure #21~18.04.1-Ubuntu SMP Wed Apr 15 09:35:56 UTC 2020 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz: 
              speed         user         nice          sys         idle          irq
       #1  2095 MHz      18837 s          0 s       1611 s      17142 s          0 s
       #2  2095 MHz      15526 s          0 s       1444 s      20459 s          0 s
       
  Memory: 6.764888763427734 GB (3567.32421875 MB free)
  Uptime: 389.0 sec
  Load Avg:  1.109375  0.890625  0.4443359375
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-8.0.1 (ORCJIT, skylake)

---

Target result

Benchmark Report for /home/runner/work/BangBang.jl/BangBang.jl

Job Properties

• Time of benchmark: 22 May 2020 - 20:55
• Package commit: e0c500
• Julia commit: 381693
• Julia command flags: None
• Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID	time	GC time	memory	allocations
["append", "append!!(::SVector, ::SingletonVector)"]	797.303 μs (5%)		1.53 MiB (1%)	100000
["append", "append!!(::Vector, ::SingletonVector)"]	401.402 μs (5%)
["append", "append!!(Empty(SVector), ::SingletonVector)"]	3.200 ns (5%)
["collectors", ":comp => \"filter\"", ":impl => \"base\""]	38.600 μs (5%)		128.66 KiB (1%)	14
["collectors", ":comp => \"filter\"", ":impl => \"coll\""]	36.100 μs (5%)		284.81 KiB (1%)	5012
["collectors", ":comp => \"filter\"", ":impl => \"nonexpanding\""]	33.100 μs (5%)		312.75 KiB (1%)	5005
["collectors", ":comp => \"filter\"", ":impl => \"vec\""]	33.600 μs (5%)		128.59 KiB (1%)	13
["collectors", ":comp => \"map\"", ":impl => \"coll\""]	5.100 μs (5%)		78.20 KiB (1%)	2
["collectors", ":comp => \"map\"", ":impl => \"man\""]	5.600 μs (5%)		78.20 KiB (1%)	2
["collectors", ":comp => \"map\"", ":impl => \"safe_coll\""]	9.300 μs (5%)		78.20 KiB (1%)	2
["collectors", ":comp => \"map\"", ":impl => \"vec\""]	57.500 μs (5%)		256.64 KiB (1%)	14
["dataframes", "Categorical"]	660.738 ms (5%)	72.765 ms	992.89 MiB (1%)	6318092
["dataframes", "Int-Int"]	934.906 μs (5%)		160.23 KiB (1%)	10251
["dataframes", "Missing-Int"]	1.186 ms (5%)		160.23 KiB (1%)	10251
["dataframes", "Missing-String"]	1.794 ms (5%)		160.27 KiB (1%)	10252
["dataframes", "String-String"]	1.652 ms (5%)		160.27 KiB (1%)	10252

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

• ["append"]
• ["collectors", ":comp => \"filter\""]
• ["collectors", ":comp => \"map\""]
• ["dataframes"]

Julia versioninfo

Julia Version 1.4.1
Commit 381693d3df* (2020-04-14 17:20 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.4 LTS
  uname: Linux 5.3.0-1020-azure #21~18.04.1-Ubuntu SMP Wed Apr 15 09:35:56 UTC 2020 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz: 
              speed         user         nice          sys         idle          irq
       #1  2095 MHz      17657 s          0 s       1549 s       9573 s          0 s
       #2  2095 MHz       7960 s          0 s       1323 s      19359 s          0 s
       
  Memory: 6.764888763427734 GB (3588.125 MB free)
  Uptime: 301.0 sec
  Load Avg:  1.0556640625  0.78076171875  0.36474609375
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-8.0.1 (ORCJIT, skylake)

---

Baseline result

Benchmark Report for /home/runner/work/BangBang.jl/BangBang.jl

Job Properties

• Time of benchmark: 22 May 2020 - 20:56
• Package commit: da093a
• Julia commit: 381693
• Julia command flags: None
• Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID	time	GC time	memory	allocations
["append", "append!!(::SVector, ::SingletonVector)"]	12.386 ms (5%)		16.78 MiB (1%)	600000
["append", "append!!(::Vector, ::SingletonVector)"]	400.501 μs (5%)
["append", "append!!(Empty(SVector), ::SingletonVector)"]	3.300 ns (5%)
["collectors", ":comp => \"filter\"", ":impl => \"base\""]	32.400 μs (5%)		128.66 KiB (1%)	14
["collectors", ":comp => \"filter\"", ":impl => \"coll\""]	38.000 μs (5%)		284.81 KiB (1%)	5012
["collectors", ":comp => \"filter\"", ":impl => \"nonexpanding\""]	41.400 μs (5%)		312.75 KiB (1%)	5005
["collectors", ":comp => \"filter\"", ":impl => \"vec\""]	33.700 μs (5%)		128.59 KiB (1%)	13
["collectors", ":comp => \"map\"", ":impl => \"coll\""]	5.400 μs (5%)		78.20 KiB (1%)	2
["collectors", ":comp => \"map\"", ":impl => \"man\""]	5.500 μs (5%)		78.20 KiB (1%)	2
["collectors", ":comp => \"map\"", ":impl => \"safe_coll\""]	10.400 μs (5%)		78.20 KiB (1%)	2
["collectors", ":comp => \"map\"", ":impl => \"vec\""]	58.800 μs (5%)		256.64 KiB (1%)	14
["dataframes", "Categorical"]	748.414 ms (5%)	79.794 ms	992.89 MiB (1%)	6318092
["dataframes", "Int-Int"]	869.303 μs (5%)		160.23 KiB (1%)	10251
["dataframes", "Missing-Int"]	1.199 ms (5%)		160.23 KiB (1%)	10251
["dataframes", "Missing-String"]	1.163 ms (5%)		160.27 KiB (1%)	10252
["dataframes", "String-String"]	1.090 ms (5%)		160.27 KiB (1%)	10252

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

• ["append"]
• ["collectors", ":comp => \"filter\""]
• ["collectors", ":comp => \"map\""]
• ["dataframes"]

Julia versioninfo

Julia Version 1.4.1
Commit 381693d3df* (2020-04-14 17:20 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.4 LTS
  uname: Linux 5.3.0-1020-azure #21~18.04.1-Ubuntu SMP Wed Apr 15 09:35:56 UTC 2020 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz: 
              speed         user         nice          sys         idle          irq
       #1  2095 MHz      18837 s          0 s       1611 s      17142 s          0 s
       #2  2095 MHz      15526 s          0 s       1444 s      20459 s          0 s
       
  Memory: 6.764888763427734 GB (3567.32421875 MB free)
  Uptime: 389.0 sec
  Load Avg:  1.109375  0.890625  0.4443359375
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-8.0.1 (ORCJIT, skylake)

---

Runtime information

Runtime Info
BLAS #threads	2
BLAS.vendor()	openblas64
Sys.CPU_THREADS	2

lscpu output:

Architecture:        x86_64
CPU op-mode(s):      32-bit, 64-bit
Byte Order:          Little Endian
CPU(s):              2
On-line CPU(s) list: 0,1
Thread(s) per core:  1
Core(s) per socket:  2
Socket(s):           1
NUMA node(s):        1
Vendor ID:           GenuineIntel
CPU family:          6
Model:               85
Model name:          Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz
Stepping:            4
CPU MHz:             2095.078
BogoMIPS:            4190.15
Hypervisor vendor:   Microsoft
Virtualization type: full
L1d cache:           32K
L1i cache:           32K
L2 cache:            1024K
L3 cache:            36608K
NUMA node0 CPU(s):   0,1
Flags:               fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm mpx avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves

Cpu Property	Value
Brand	Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz
Vendor	:Intel
Architecture	:Skylake
Model	Family: 0x06, Model: 0x55, Stepping: 0x04, Type: 0x00
Cores	2 physical cores, 2 logical cores (on executing CPU)
	No Hyperthreading detected
Clock Frequencies	Not supported by CPU
Data Cache	Level 1:3 : (32, 1024, 36608) kbytes
	64 byte cache line size
Address Size	48 bits virtual, 44 bits physical
SIMD	512 bit = 64 byte max. SIMD vector size
Time Stamp Counter	TSC is accessible via rdtsc
	TSC increased at every clock cycle (non-invariant TSC)
Perf. Monitoring	Performance Monitoring Counters (PMC) are not supported
Hypervisor	Yes, Microsoft