Fix Zip performance penalty #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11 +/- ##
==========================================
+ Coverage 81.21% 82.69% +1.47%
==========================================
Files 8 8
Lines 740 861 +121
==========================================
+ Hits 601 712 +111
- Misses 139 149 +10
Continue to review full report at Codecov.
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch moves all output type inference out of foldl. This is done by creating a static
Reductiontree that stores input/output type:https://github.com/tkf/Transducers.jl/blob/6c014f884410a24dc7b139da4050ce9f56157cda/src/library.jl#L1333-L1357
foreach SIMD test with
Zip(Count(), xf_double)now works.Remaining problems (as of 6c014f8):
map!IR test does not produce SIMD (and the benchmark is slow)