Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't restack if pointer-free #504

Closed
wants to merge 2 commits into from
Closed

Don't restack if pointer-free #504

wants to merge 2 commits into from

Conversation

tkf
Copy link
Member

@tkf tkf commented Jan 29, 2022

No description provided.

@codecov
Copy link

codecov bot commented Jan 29, 2022

Codecov Report

Merging #504 (4543026) into master (3f52fa9) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #504      +/-   ##
==========================================
+ Coverage   93.41%   93.45%   +0.04%     
==========================================
  Files          32       32              
  Lines        2217     2217              
==========================================
+ Hits         2071     2072       +1     
+ Misses        146      145       -1     
Flag Coverage Δ
Pkg.test 89.62% <100.00%> (+0.04%) ⬆️
Run.test 93.27% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/AutoObjectsReStacker.jl 95.65% <100.00%> (ø)
src/nondeterministic_threading.jl 89.79% <0.00%> (+1.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f52fa9...4543026. Read the comment docs.

@tkf
Copy link
Member Author

tkf commented Jan 30, 2022

It looks like restack still matters for pointer-free types https://github.com/JuliaFolds/Transducers-data/blob/multi-thread-benchmark-results/2022/01/29/054144/result.md

ID time ratio memory ratio
... ... ...
["partition_length_maximum", "rand", "reduce"] 5.07 (5%) ❌ 1.00 (1%)

See also:

@tkf tkf closed this Jan 30, 2022
@tkf tkf deleted the restack branch January 30, 2022 03:40
@tkf tkf changed the title Less restack Don't restack if pointer-free Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant