Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental completebasecase protocol #509

Merged
merged 4 commits into from
Jan 30, 2022
Merged

Add experimental completebasecase protocol #509

merged 4 commits into from
Jan 30, 2022

Conversation

tkf
Copy link
Member

@tkf tkf commented Jan 30, 2022

No description provided.

@codecov
Copy link

codecov bot commented Jan 30, 2022

Codecov Report

Merging #509 (2601be1) into master (3541502) will decrease coverage by 0.88%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #509      +/-   ##
==========================================
- Coverage   93.45%   92.57%   -0.89%     
==========================================
  Files          32       32              
  Lines        2217     2223       +6     
==========================================
- Hits         2072     2058      -14     
- Misses        145      165      +20     
Flag Coverage Δ
Pkg.test 89.65% <100.00%> (+0.03%) ⬆️
Run.test 92.39% <100.00%> (-0.89%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/combinators.jl 96.61% <100.00%> (+0.31%) ⬆️
src/core.jl 89.76% <100.00%> (-0.80%) ⬇️
src/processes.jl 94.19% <100.00%> (ø)
src/reduce.jl 72.56% <0.00%> (-9.89%) ⬇️
src/basics.jl 88.88% <0.00%> (-5.56%) ⬇️
src/partitionby.jl 90.90% <0.00%> (-3.90%) ⬇️
src/progress.jl 91.58% <0.00%> (-0.94%) ⬇️
src/library.jl 95.81% <0.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3541502...2601be1. Read the comment docs.

@tkf tkf changed the title Add completebasecase protocol Add experimental completebasecase protocol Jan 30, 2022
@tkf tkf enabled auto-merge (squash) January 30, 2022 18:09
@tkf tkf disabled auto-merge January 30, 2022 18:17
@tkf tkf enabled auto-merge (squash) January 30, 2022 18:50
@tkf tkf merged commit 556c500 into master Jan 30, 2022
@tkf tkf deleted the completebasecase branch January 30, 2022 20:05
tkf added a commit that referenced this pull request Feb 3, 2022
Fix a bug introduced in #511 for the protocol introduced in #509.
tkf added a commit that referenced this pull request Feb 3, 2022
Fix a bug introduced in #511 for the protocol introduced in #509.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant