Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better example of GetIndex #547

Merged
merged 1 commit into from
Nov 28, 2022
Merged

Better example of GetIndex #547

merged 1 commit into from
Nov 28, 2022

Conversation

MasonProtter
Copy link
Member

I think the old example didn't really make it clear which array was being indexed into, and which one was the source of indices. This example makes that more clear.

@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Merging #547 (edf05b7) into master (142abcb) will decrease coverage by 0.58%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #547      +/-   ##
==========================================
- Coverage   95.43%   94.84%   -0.59%     
==========================================
  Files          32       32              
  Lines        2233     2231       -2     
==========================================
- Hits         2131     2116      -15     
- Misses        102      115      +13     
Flag Coverage Δ
Pkg.test 94.46% <ø> (-0.09%) ⬇️
Run.test 94.71% <ø> (-0.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/library.jl 98.70% <ø> (+0.25%) ⬆️
src/basics.jl 88.88% <0.00%> (-5.56%) ⬇️
src/partitionby.jl 90.90% <0.00%> (-3.90%) ⬇️
src/nondeterministic_threading.jl 88.77% <0.00%> (-2.05%) ⬇️
src/reduce.jl 94.59% <0.00%> (-1.84%) ⬇️
src/progress.jl 91.58% <0.00%> (-0.94%) ⬇️
src/core.jl 92.12% <0.00%> (-0.93%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@MasonProtter MasonProtter enabled auto-merge (rebase) November 28, 2022 18:45
@MasonProtter MasonProtter merged commit f8d0dfe into master Nov 28, 2022
@MasonProtter MasonProtter deleted the better-GetIndex-example2 branch November 28, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant