Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MIOpen softmax & batchnorm #630

Merged
merged 2 commits into from
May 15, 2024
Merged

Remove MIOpen softmax & batchnorm #630

merged 2 commits into from
May 15, 2024

Conversation

pxl-th
Copy link
Collaborator

@pxl-th pxl-th commented May 15, 2024

NNlib has pure Julia implementation for both and MIOpen softmax has issues: ROCm/MIOpen#2966

NNlib has pure Julia implementations of those.
@pxl-th pxl-th merged commit c2fe803 into master May 15, 2024
1 check was pending
@pxl-th pxl-th deleted the pxl-th/miopen branch May 15, 2024 16:51
@atamazov
Copy link

Note that ROCm/MIOpen#2966 won't manifest itself unless the same instance of the library is used to get softmax for different datatypes.

The fix in on the way: ROCm/MIOpen#2992

@pxl-th
Copy link
Collaborator Author

pxl-th commented May 27, 2024

Note that ROCm/MIOpen#2966 won't manifest itself unless the same instance of the library is used to get softmax for different datatypes.

Yes, that's exactly what we were doing. We run tests for different types in the same session and users are generally not restricted to what types they can use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants