Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a macro for marking multiple functions as device-only. #1117

Merged
merged 1 commit into from
Aug 26, 2021

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Aug 26, 2021

Use it to mark the indexing functions like that. Makes #1116 error instead of segfault.

Use it to mark the indexing functions like that.
@maleadt maleadt added the enhancement New feature or request label Aug 26, 2021
@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #1117 (faa3387) into master (b04eb2f) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1117      +/-   ##
==========================================
- Coverage   79.45%   79.43%   -0.02%     
==========================================
  Files         118      118              
  Lines        7920     7996      +76     
==========================================
+ Hits         6293     6352      +59     
- Misses       1627     1644      +17     
Impacted Files Coverage Δ
lib/utils/threading.jl 74.07% <0.00%> (-1.93%) ⬇️
lib/cudnn/CUDNN.jl 75.40% <0.00%> (-1.26%) ⬇️
src/utilities.jl 88.70% <0.00%> (-0.95%) ⬇️
lib/cudnn/convolution.jl 67.05% <0.00%> (-0.80%) ⬇️
lib/cudnn/rnn.jl 71.30% <0.00%> (-0.63%) ⬇️
lib/cublas/CUBLAS.jl 76.57% <0.00%> (-0.49%) ⬇️
src/state.jl 77.97% <0.00%> (-0.47%) ⬇️
src/sorting.jl 21.00% <0.00%> (-0.30%) ⬇️
lib/cufft/fft.jl 83.69% <0.00%> (-0.19%) ⬇️
src/pool.jl 75.94% <0.00%> (-0.14%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b04eb2f...faa3387. Read the comment docs.

@maleadt maleadt merged commit 9b2d508 into master Aug 26, 2021
@maleadt maleadt deleted the tb/device_functions branch August 26, 2021 10:01
simonbyrne pushed a commit to simonbyrne/CUDA.jl that referenced this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant