Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary dependency changes #1159

Merged
merged 9 commits into from Sep 23, 2021
Merged

Binary dependency changes #1159

merged 9 commits into from Sep 23, 2021

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Sep 22, 2021

Couple of changes:

  • expose the runtime library -- some users require it, https://discourse.julialang.org/t/shared-c-dependencies-and-artifacts/68525
  • use cudart for detecting the toolkit version, not ptxas
  • remove the version database, users with local toolkits should provide unversioned (development) libraries
  • ... except for Windows, where libraries are always versioned. brute-force the name there.

@maleadt maleadt added the installation CUDA is easy to install, right? label Sep 22, 2021
@maleadt maleadt changed the title Dependency management fixes Binary dependency changes Sep 22, 2021
@codecov
Copy link

codecov bot commented Sep 23, 2021

Codecov Report

Merging #1159 (ef274d3) into master (28d4ab7) will increase coverage by 0.40%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1159      +/-   ##
==========================================
+ Coverage   80.35%   80.76%   +0.40%     
==========================================
  Files         118      121       +3     
  Lines        8100     8218     +118     
==========================================
+ Hits         6509     6637     +128     
+ Misses       1591     1581      -10     
Impacted Files Coverage Δ
src/utilities.jl 87.30% <75.00%> (-1.41%) ⬇️
lib/cudadrv/version.jl 100.00% <100.00%> (ø)
lib/utils/memoization.jl 90.90% <0.00%> (-3.54%) ⬇️
src/CUDA.jl 100.00% <0.00%> (ø)
lib/nvtx/NVTX.jl 100.00% <0.00%> (ø)
lib/cudnn/descriptors.jl 100.00% <0.00%> (ø)
lib/utils/APIUtils.jl 100.00% <0.00%> (ø)
lib/cufft/CUFFT.jl 100.00% <0.00%> (ø)
lib/cupti/CUPTI.jl 100.00% <0.00%> (ø)
lib/cusolver/CUSOLVER.jl 86.76% <0.00%> (+0.19%) ⬆️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebe4c20...ef274d3. Read the comment docs.

@maleadt maleadt merged commit 45f65b3 into master Sep 23, 2021
@maleadt maleadt deleted the tb/bindeps branch September 23, 2021 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installation CUDA is easy to install, right?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant