[CUSOLVER] Add ordering functions #1198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maleadt
requested changes
Oct 12, 2021
lib/cusolver/ordering.jl
Outdated
| rowsA = A.rowPtr |> Vector{Cint} | ||
| colsA = A.colVal |> Vector{Cint} | ||
| p = zeros(Cint, n) | ||
| cusolverSpXcsrsymrcmHost(sparse_handle(), n, nnz(A), descA, rowsA, colsA, p) |
There was a problem hiding this comment.
Why do you use the host APIs here?
There was a problem hiding this comment.
symrcm,symmdq,symamdandmetisndare used insidecusolverRF(Add a wrapper to cusolverRF in CUSOLVER #828) but no low-level wrappers are implemented.zfdshould be combined in practice withilu0routine (incomplete LU factorization) because the factorization is done without pivoting and if one diagonal element is zero the factorization failed.
There was a problem hiding this comment.
Ah, there aren't any device equivalents for these APIs...
lib/cusolver/ordering.jl
Outdated
| n, m = A.dims | ||
| (m ≠ m) && throw(DimensionMismatch("A must be square, but has dimensions ($n,$m)!")) | ||
| descA = CUSPARSE.CuMatrixDescriptor('G', 'L', 'N', index) | ||
| rowsA = A.rowPtr |> Vector{Cint} |
maleadt
added
cuda libraries
|
@maleadt I take into account all your comments. |
Codecov Report
@@ Coverage Diff @@
## master #1198 +/- ##
===========================================
+ Coverage 0.49% 80.45% +79.96%
===========================================
Files 118 119 +1
Lines 7953 8374 +421
===========================================
+ Hits 39 6737 +6698
+ Misses 7914 1637 -6277
Continue to review full report at Codecov.
|
amontoison
commented
Oct 19, 2021
|
Thanks, looks good! |
xaellison
pushed a commit
to xaellison/CUDA.jl
that referenced
this pull request
Oct 20, 2021
simonbyrne
pushed a commit
to simonbyrne/CUDA.jl
that referenced
this pull request
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.