-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expose sparse mv/mm algo selection #1201
expose sparse mv/mm algo selection #1201
Conversation
I thought the current tests cover this already tho? Or we should test on other algorithms? |
How? Didn't you introduce the |
hmm I'm a bit confused why the test is failing on CUDA 11.1, I've filter the tests to not run below CUDA 11.2, but somehow it still get executed on those versions, what would be right way of doing this? |
|
Please rebase on master to not require Windows to pass. |
Codecov Report
@@ Coverage Diff @@
## master #1201 +/- ##
==========================================
- Coverage 77.36% 76.62% -0.75%
==========================================
Files 120 120
Lines 9274 9273 -1
==========================================
- Hits 7175 7105 -70
- Misses 2099 2168 +69
Continue to review full report at Codecov.
|
LGTM, thanks! |
this is a simple change to expose the algorithm parameter to mv/mm level
edit: I'm not sure if we should check if the selected algo match the input, e.g some algo only work on CSR with col/row-major