Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding stream update for inplace complex FFT #1269

Merged
merged 1 commit into from
Dec 13, 2021

Conversation

ovanvincq
Copy link
Contributor

@ovanvincq ovanvincq commented Dec 10, 2021

Fixes #1268

@maleadt maleadt added needs tests Tests are requested. bugfix This gets something working again. cuda libraries Stuff about CUDA library wrappers. labels Dec 10, 2021
@maleadt
Copy link
Member

maleadt commented Dec 10, 2021

Thanks! Since you had a compact reproducer, maybe add that as a test?

@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #1269 (33aa453) into master (9636915) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1269      +/-   ##
==========================================
+ Coverage   78.95%   79.01%   +0.06%     
==========================================
  Files         119      119              
  Lines        8544     8627      +83     
==========================================
+ Hits         6746     6817      +71     
- Misses       1798     1810      +12     
Impacted Files Coverage Δ
lib/cufft/fft.jl 89.16% <100.00%> (+1.99%) ⬆️
lib/utils/threading.jl 74.07% <0.00%> (-1.93%) ⬇️
src/utilities.jl 78.46% <0.00%> (-1.87%) ⬇️
lib/cudnn/CUDNN.jl 74.60% <0.00%> (-1.21%) ⬇️
lib/cudnn/convolution.jl 67.05% <0.00%> (-0.80%) ⬇️
lib/cudnn/rnn.jl 73.04% <0.00%> (-0.65%) ⬇️
src/pool.jl 76.79% <0.00%> (-0.60%) ⬇️
lib/cublas/CUBLAS.jl 76.57% <0.00%> (-0.49%) ⬇️
src/state.jl 79.09% <0.00%> (-0.45%) ⬇️
src/sorting.jl 23.91% <0.00%> (-0.09%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9636915...33aa453. Read the comment docs.

@maleadt maleadt merged commit c2e1c69 into JuliaGPU:master Dec 13, 2021
simonbyrne pushed a commit to simonbyrne/CUDA.jl that referenced this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This gets something working again. cuda libraries Stuff about CUDA library wrappers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inplace Complex FFT and Threads
2 participants