Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sort! return type. #1272

Merged
merged 1 commit into from
Dec 10, 2021
Merged

Fix sort! return type. #1272

merged 1 commit into from
Dec 10, 2021

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Dec 10, 2021

Fixes #1270

@maleadt maleadt added cuda array Stuff about CuArray. bugfix This gets something working again. labels Dec 10, 2021
@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #1272 (01665dd) into master (9636915) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1272      +/-   ##
==========================================
- Coverage   78.95%   78.94%   -0.01%     
==========================================
  Files         119      119              
  Lines        8544     8627      +83     
==========================================
+ Hits         6746     6811      +65     
- Misses       1798     1816      +18     
Impacted Files Coverage Δ
src/sorting.jl 24.09% <100.00%> (+0.09%) ⬆️
lib/utils/threading.jl 74.07% <0.00%> (-1.93%) ⬇️
src/utilities.jl 78.46% <0.00%> (-1.87%) ⬇️
lib/cudnn/CUDNN.jl 74.60% <0.00%> (-1.21%) ⬇️
lib/cudnn/convolution.jl 67.05% <0.00%> (-0.80%) ⬇️
lib/cudnn/rnn.jl 73.04% <0.00%> (-0.65%) ⬇️
src/pool.jl 76.79% <0.00%> (-0.60%) ⬇️
lib/cublas/CUBLAS.jl 76.57% <0.00%> (-0.49%) ⬇️
src/state.jl 79.09% <0.00%> (-0.45%) ⬇️
lib/cufft/fft.jl 86.95% <0.00%> (-0.23%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9636915...01665dd. Read the comment docs.

@maleadt maleadt merged commit 5baddd3 into master Dec 10, 2021
@maleadt maleadt deleted the tb/sort branch December 10, 2021 19:26
simonbyrne pushed a commit to simonbyrne/CUDA.jl that referenced this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This gets something working again. cuda array Stuff about CuArray.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sort returns nothing
1 participant