Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle missing cached_memory. #1295

Merged
merged 1 commit into from Dec 29, 2021
Merged

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Dec 24, 2021

@maleadt maleadt added bugfix This gets something working again. cuda libraries Stuff about CUDA library wrappers. labels Dec 24, 2021
@codecov
Copy link

codecov bot commented Dec 24, 2021

Codecov Report

Merging #1295 (40be487) into master (35d8147) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1295   +/-   ##
=======================================
  Coverage   78.94%   78.94%           
=======================================
  Files         119      119           
  Lines        8650     8650           
=======================================
  Hits         6829     6829           
  Misses       1821     1821           
Impacted Files Coverage Δ
lib/cudnn/convolution.jl 67.05% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09ec093...40be487. Read the comment docs.

@ToucheSir
Copy link
Contributor

Confirmed no errors raised running with this locally.

@DhairyaLGandhi
Copy link
Member

Awesome! Per https://discourse.julialang.org/t/flux-60-minute-blitz-weird-error-when-using-gpu/73537/7?u=dhairyagandhi96 this should resolve the OP as well. Let's merge this once we get a reply on the thread about the version of the driver. Fwiw, it would work on new CUDA drivers so Flux's ci wouldn't catch it easily.

@maleadt maleadt merged commit 0396063 into master Dec 29, 2021
@maleadt maleadt deleted the tb/missing_cached_memory branch December 29, 2021 08:57
simonbyrne pushed a commit to simonbyrne/CUDA.jl that referenced this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This gets something working again. cuda libraries Stuff about CUDA library wrappers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants