Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CUSPARSE BSR improvements #1409

Merged
merged 3 commits into from
Feb 25, 2022
Merged

CUSPARSE BSR improvements #1409

merged 3 commits into from
Feb 25, 2022

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Feb 25, 2022

  • make nnz return the number of nonzero elements, and not the number of nonzero blocks.
  • add indexing support
  • fix BSR to CSR conversion

It cannot just report the number of nonzero blocks,
but should return the number of contained elements.
@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #1409 (799faa9) into master (a50e85c) will decrease coverage by 0.07%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1409      +/-   ##
==========================================
- Coverage   77.05%   76.97%   -0.08%     
==========================================
  Files         124      124              
  Lines        9186     9209      +23     
==========================================
+ Hits         7078     7089      +11     
- Misses       2108     2120      +12     
Impacted Files Coverage Δ
lib/cusparse/array.jl 64.98% <45.45%> (-1.69%) ⬇️
lib/cusparse/conversions.jl 81.48% <100.00%> (-0.08%) ⬇️
lib/cusparse/level2.jl 90.32% <100.00%> (ø)
lib/cusparse/level3.jl 75.00% <100.00%> (ø)
lib/cupti/error.jl 66.66% <0.00%> (-3.34%) ⬇️
lib/cutensor/error.jl 41.17% <0.00%> (-2.58%) ⬇️
lib/cufft/error.jl 38.88% <0.00%> (-2.29%) ⬇️
lib/utils/memoization.jl 86.27% <0.00%> (+0.27%) ⬆️
lib/cusparse/error.jl 94.73% <0.00%> (+0.29%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a50e85c...799faa9. Read the comment docs.

@maleadt maleadt merged commit 285c7a5 into master Feb 25, 2022
@maleadt maleadt deleted the tb/sparse_bsr branch February 25, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant