Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CUSTATEVEC and CUTENSORNET into lib/ #1478

Merged
merged 1 commit into from
May 9, 2022
Merged

Move CUSTATEVEC and CUTENSORNET into lib/ #1478

merged 1 commit into from
May 9, 2022

Conversation

vchuravy
Copy link
Member

No description provided.

@vchuravy vchuravy requested a review from kshyatt April 15, 2022 14:16
@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #1478 (a00c20a) into master (778f7fa) will decrease coverage by 4.63%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1478      +/-   ##
==========================================
- Coverage   77.28%   72.65%   -4.64%     
==========================================
  Files         120      130      +10     
  Lines        9271     9777     +506     
==========================================
- Hits         7165     7103      -62     
- Misses       2106     2674     +568     
Impacted Files Coverage Δ
lib/CUSTATEVEC/src/CUSTATEVEC.jl 0.00% <ø> (ø)
lib/CUSTATEVEC/src/error.jl 0.00% <ø> (ø)
lib/CUSTATEVEC/src/libcustatevec.jl 0.00% <ø> (ø)
lib/CUSTATEVEC/src/statevec.jl 0.00% <ø> (ø)
lib/CUSTATEVEC/src/types.jl 0.00% <ø> (ø)
lib/CUTENSORNET/src/CUTENSORNET.jl 0.00% <ø> (ø)
lib/CUTENSORNET/src/error.jl 0.00% <ø> (ø)
lib/CUTENSORNET/src/libcutensornet.jl 0.00% <ø> (ø)
lib/CUTENSORNET/src/tensornet.jl 0.00% <ø> (ø)
lib/CUTENSORNET/src/types.jl 0.00% <ø> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 778f7fa...a00c20a. Read the comment docs.

@maleadt
Copy link
Member

maleadt commented Apr 17, 2022

LGTM. Should we use lowercase directory filenames too? NVIDIA isn't always consistent either (e.g. cuSOLVER vs cuQuantum), but that doesn't mean we can't be.

@maleadt maleadt merged commit 28b1ff4 into master May 9, 2022
@maleadt maleadt deleted the vc/mv_to_lib branch May 9, 2022 07:24
simonbyrne pushed a commit to simonbyrne/CUDA.jl that referenced this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants