Adapt to GPUCompiler 0.15 changes #1488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maleadt
force-pushed
the
tb/gpucompiler
branch
2 times, most recently
from
6f4b8a8
to
9d54aad
Compare
GPUCompiler doesn't know about the function instance anymore, so create the HostKernel when we still do.
Codecov Report
@@ Coverage Diff @@
## master #1488 +/- ##
==========================================
- Coverage 73.31% 72.63% -0.69%
==========================================
Files 131 131
Lines 9805 9806 +1
==========================================
- Hits 7189 7123 -66
- Misses 2616 2683 +67
Continue to review full report at Codecov.
|
simonbyrne
pushed a commit
to simonbyrne/CUDA.jl
that referenced
this pull request
Nov 13, 2023
* Bump GPUCompiler. * Adapt to FunctionSpec change. GPUCompiler doesn't know about the function instance anymore, so create the HostKernel when we still do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remaining issues need a fix in GPUCompiler: JuliaGPU/GPUCompiler.jl#320 (comment)