Add a new cache for HostKernel objects. #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that GPUCompiler's compilation (and compilation cache) is using the function type, we need to allocate HostKernel objects in CUDA.jl where we still have access to the function instance. Doing so is relatively slow, so introduce another cache.
maleadt
force-pushed
the
tb/launch_overhead
branch
from
f7857e3
to
70ec0cd
Compare
Codecov Report
@@ Coverage Diff @@
## master #1510 +/- ##
==========================================
- Coverage 73.53% 72.90% -0.64%
==========================================
Files 131 131
Lines 9825 9834 +9
==========================================
- Hits 7225 7169 -56
- Misses 2600 2665 +65
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that GPUCompiler's compilation (and compilation cache) is using the function type,
we need to allocate HostKernel objects in CUDA.jl where we still have access to
the function instance. Doing so is relatively slow, so introduce another cache.
cc @jpsamaroo AMDGPU.jl probably needs something similar.