Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop pirating GPUArrays' RNG methods. #1735

Merged
merged 1 commit into from
Jan 20, 2023
Merged

Stop pirating GPUArrays' RNG methods. #1735

merged 1 commit into from
Jan 20, 2023

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Jan 20, 2023

@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Base: 59.99% // Head: 59.69% // Decreases project coverage by -0.31% ⚠️

Coverage data is based on head (c55fe24) compared to base (b115925).
Patch coverage: 92.30% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1735      +/-   ##
==========================================
- Coverage   59.99%   59.69%   -0.31%     
==========================================
  Files         148      148              
  Lines       12038    12037       -1     
==========================================
- Hits         7222     7185      -37     
- Misses       4816     4852      +36     
Impacted Files Coverage Δ
src/random.jl 67.45% <92.30%> (ø)
lib/cublas/error.jl 0.00% <0.00%> (-75.00%) ⬇️
lib/cublas/CUBLAS.jl 52.63% <0.00%> (-23.69%) ⬇️
src/utilities.jl 67.10% <0.00%> (-9.22%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maleadt maleadt merged commit dcf1cf1 into master Jan 20, 2023
@maleadt maleadt deleted the tb/rng_pirate branch January 20, 2023 11:06
maleadt added a commit that referenced this pull request Jan 20, 2023
Stop pirating GPUArrays' RNG methods.
maleadt added a commit that referenced this pull request Jan 20, 2023
Stop pirating GPUArrays' RNG methods.
@omlins
Copy link
Contributor

omlins commented Jan 27, 2023

Thanks for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

method ambiguity in rand!
2 participants