Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump GPUCompiler. #1787

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Bump GPUCompiler. #1787

merged 1 commit into from
Mar 10, 2023

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Mar 8, 2023

Should make 1.9 CI work again.

@maleadt
Copy link
Member Author

maleadt commented Mar 8, 2023

@vchuravy You already tested -rc1; did you encounter these regressions?
beta4 worked fine: https://buildkite.com/julialang/cuda-dot-jl/builds/3631#0186b5ba-3223-48f3-b6f4-6f6a40416eaa

cc @KristofferC, just so you know that something may be up with -rc1/GPU back-ends/kwcall.

@vchuravy
Copy link
Member

vchuravy commented Mar 9, 2023

Sorry I had only ran the GPUCompiler tests

@maleadt
Copy link
Member Author

maleadt commented Mar 9, 2023

Smells like JuliaLang/julia#48097

@maleadt
Copy link
Member Author

maleadt commented Mar 9, 2023

09757f7c83f91b8428f8229375f77810fa829683 is the first bad commit
commit 09757f7c83f91b8428f8229375f77810fa829683
Author: Shuhei Kadowaki <40514306+aviatesk@users.noreply.github.com>
Date:   Wed Mar 1 19:07:59 2023 +0900

    effects: taint `nonoverlayed` when bailing out inference (#48838)

@aviatesk Any thoughts on which JuliaLang/julia#48838 broke kwcall in GPU code again? This due to the presence of overlay methods (seeing how we overlay Core.throw_inexacterror), but we can't fix the underlying issue in time for 1.9, so that's why I did JuliaLang/julia#48116 when last looking at this.

Also, what's the reason you backported that PR? It doesn't reference anything it fixes, nor ever had the backport label (or a discussion on whether it should). So maybe the easiest "fix" is to revert that change?

x-ref JuliaGPU/GPUCompiler.jl#384

@maleadt
Copy link
Member Author

maleadt commented Mar 10, 2023

Merging this and moving the discussion to an issue.

@maleadt maleadt merged commit 641d190 into master Mar 10, 2023
@maleadt maleadt deleted the tb/bump branch March 10, 2023 14:08
simonbyrne pushed a commit to simonbyrne/CUDA.jl that referenced this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants