Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include potri and test #179

Merged
merged 1 commit into from
May 29, 2020
Merged

include potri and test #179

merged 1 commit into from
May 29, 2020

Conversation

erathorn
Copy link
Contributor

This mirrors PR #730 from CuArrays

This PR addes potri! and accompanying tests.
Possibly an improvement to #440 (from CuArrays)

@maleadt maleadt added cuda array Stuff about CuArray. enhancement New feature or request labels May 27, 2020
@maleadt
Copy link
Member

maleadt commented May 27, 2020

bors try

bors bot added a commit that referenced this pull request May 27, 2020
@bors
Try #179:
331c051
@bors
Copy link
Contributor

bors bot commented May 27, 2020

try

Build failed:

@maleadt
Copy link
Member

maleadt commented May 27, 2020

allowscalar and unsafe_free have already been imported into CUSOLVER, so you don't need to specify.

@erathorn
Copy link
Contributor Author

The relevant tests seem to pass on my machine.

@bors
Copy link
Contributor

bors bot commented May 27, 2020

🔒 Permission denied

Existing reviewers: click here to make erathorn a reviewer

@maleadt
Copy link
Member

maleadt commented May 27, 2020

Please don't commit merge conflicts and their resolution; you should rebase on top of master.

@erathorn
Copy link
Contributor Author

Sorry for the mess. I cleaned up the code and messages.

@maleadt
Copy link
Member

maleadt commented May 27, 2020

bors r+

bors bot added a commit that referenced this pull request May 27, 2020
@bors @erathorn
Merge #179
6531589 
179: include potri and test r=maleadt a=erathorn

This mirrors PR #730 from CuArrays

> This PR addes potri! and accompanying tests.
> Possibly an improvement to #440 (from CuArrays)

Co-authored-by: erathorn <erathorn@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented May 27, 2020

Build failed:

@maleadt
Copy link
Member

maleadt commented May 27, 2020 •
edited 

 Error in testset cusolver:
Error During Test at /builds/JuliaGPU/CUDA.jl/test/cusolver.jl:43
  Got exception outside of a @test
  could not load symbol "cusolverDnZpotri_bufferSize":
  /builds/JuliaGPU/CUDA.jl/.julia/artifacts/9c5665f3f80231f7ed3afa44d46dfd8f8fd7c5c2/lib/libcusolver.so: undefined symbol: cusolverDnZpotri_bufferSize

You'll have to guard the functionality and its tests on the version().

EDIT: actually, only guard the tests, but maybe add a !!! note to the docstrings about compatibility.

@erathorn erathorn force-pushed the master branch 2 times, most recently from d461a66 to c4145dd Compare May 28, 2020 11:54
@erathorn
Copy link
Contributor Author

I added the guards for the test and a !!! note at potri().

@maleadt
Copy link
Member

maleadt commented May 29, 2020

bors r+

bors bot added a commit that referenced this pull request May 29, 2020
@bors @erathorn
Merge #179
1bf2e96 
179: include potri and test r=maleadt a=erathorn

This mirrors PR #730 from CuArrays

> This PR addes potri! and accompanying tests.
> Possibly an improvement to #440 (from CuArrays)

Co-authored-by: erathorn <erathorn@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented May 29, 2020

Timed out.

@maleadt maleadt merged commit 6ee3739 into JuliaGPU:master May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cuda array Stuff about CuArray. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@erathorn @maleadt