New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Atomix #1790
Draft
vchuravy
wants to merge
32
commits into
master
Choose a base branch
from
vc/atomix
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Use Atomix #1790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Formerly know as CUDAKernels.jl
References:
Notes:
|
@tkf if you have some time/interest in looking over my implementation. I intend to replace AtomicxCuda. |
So a significant difference between
whereas
Base agrees with Atomix.
|
vchuravy
force-pushed
the
vc/ka_transition
branch
from
March 21, 2023 16:21
1f8cfa3
to
419ff9b
Compare
This was referenced Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just blindly using UnsafeAtomicsLLVM sadly doesn't work
since LLVM doesn't understand CUDA atomics...
Uses most of #1644 to implement Atomicx.jl properly.
cas
forsize(T) < 4
Atomix.swap!
by usingatomic_exchange
Atomix.modify!
by using hardware implementation of common functionsld.volatile.global.u16 %rs1, [%rd2];
take AS into account, needed for shmem correctness.