fix sparse CSC gemm and test (closes #181) #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closes #181 |
|
I also simplified the tests; a lot of arrays were being |
maleadt
added
bugfix
|
Thanks! I think @kshyatt wrote most of these tests, maybe she can elaborate. |
tryBuild succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like everything was there except that instead of returning a CSC matrix, because we do the gemm with the CSR routines a CSR matrix is returned. I think that's OK though we could also convert back to CSC if we wanted.
Either way, it seems like these routines are deprecated, and that we should switch to using csrgemm2
I added a test for both CSR & CSC methods to test the transposed operation.
I also fixed a typo with the
indexCargument.