Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added wrappers for cusolverDn<t>potrfBatched #192

Merged
merged 3 commits into from
Jun 5, 2020
Merged

Added wrappers for cusolverDn<t>potrfBatched #192

merged 3 commits into from
Jun 5, 2020

Conversation

IvanYashchuk
Copy link
Contributor

I've added wrappers for cusolver's potrfBatched routine. It is working over the Vector of CuArrays. Tests are there as well.

@maleadt maleadt added cuda array Stuff about CuArray. enhancement New feature or request labels Jun 3, 2020
@maleadt
Copy link
Member

maleadt commented Jun 3, 2020

Thanks!
bors r+

bors bot added a commit that referenced this pull request Jun 3, 2020
@bors @IvanYashchuk
Merge #192
ca95ec1 
192: Added wrappers for cusolverDn<t>potrfBatched r=maleadt a=IvanYashchuk

I've added wrappers for cusolver's potrfBatched routine. It is working over the Vector of CuArrays. Tests are there as well.

Co-authored-by: Ivan Yashchuk <ivan.yashchuk@aalto.fi>
@bors
Copy link
Contributor

bors bot commented Jun 3, 2020

This PR was included in a batch that successfully built, but then failed to merge into master (it was a non-fast-forward update). It will be automatically retried.

@IvanYashchuk
Copy link
Contributor Author

@maleadt, I am not familiar with bors. What should I do in this case, rebase on current master?

@maleadt
Copy link
Member

maleadt commented Jun 3, 2020

It should do that automatically... Let's try again manually, then:
bors r+

@bors
Copy link
Contributor

bors bot commented Jun 3, 2020

Already running a review

@maleadt
Copy link
Member

maleadt commented Jun 3, 2020

bors try-

@maleadt
Copy link
Member

maleadt commented Jun 3, 2020

It says merge conflict, but GitHub doesn't... Maybe try rebasing, yes.

bors bot added a commit that referenced this pull request Jun 3, 2020
@bors @IvanYashchuk
Merge #192
3ba750f 
192: Added wrappers for cusolverDn<t>potrfBatched r=maleadt a=IvanYashchuk

I've added wrappers for cusolver's potrfBatched routine. It is working over the Vector of CuArrays. Tests are there as well.

Co-authored-by: Ivan Yashchuk <ivan.yashchuk@aalto.fi>
@bors
Copy link
Contributor

bors bot commented Jun 3, 2020

Canceled.

@IvanYashchuk
Copy link
Contributor Author

I've rebased to master.

@kshyatt
Copy link
Contributor

kshyatt commented Jun 4, 2020

bors r+

bors bot added a commit that referenced this pull request Jun 4, 2020
@bors @IvanYashchuk
Merge #192
777dfdb 
192: Added wrappers for cusolverDn<t>potrfBatched r=kshyatt a=IvanYashchuk

I've added wrappers for cusolver's potrfBatched routine. It is working over the Vector of CuArrays. Tests are there as well.

Co-authored-by: Ivan Yashchuk <ivan.yashchuk@aalto.fi>
@bors
Copy link
Contributor

bors bot commented Jun 4, 2020

Build failed:

@maleadt
Copy link
Member

maleadt commented Jun 4, 2020

Build failure was an OOM, so that should be good. Needs another rebase though...

@IvanYashchuk
Copy link
Contributor Author

@maleadt, can you try it again now?

@maleadt
Copy link
Member

maleadt commented Jun 5, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 5, 2020

Build succeeded:

@bors bors bot merged commit d5c63eb into JuliaGPU:master Jun 5, 2020
@IvanYashchuk IvanYashchuk deleted the potrf-batched branch June 5, 2020 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cuda array Stuff about CuArray. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@IvanYashchuk @maleadt @kshyatt