Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of srcPos and dstPos in unsafe_copy3d! #197

Merged
merged 2 commits into from
Jun 3, 2020
Merged

Fix handling of srcPos and dstPos in unsafe_copy3d! #197

merged 2 commits into from
Jun 3, 2020

Conversation

samo-lin
Copy link
Contributor

@samo-lin samo-lin commented Jun 3, 2020

Closes #27

@samo-lin
Copy link
Contributor Author

samo-lin commented Jun 3, 2020

@maleadt, from my point of view this is all fine for merging.

@samo-lin
Copy link
Contributor Author

samo-lin commented Jun 3, 2020

Here are the test results:

> julia
julia> using CUDA, Test

julia> include("test/cuda/memory.jl")
Test Summary: | Pass  Broken  Total
memory        |   48       1     49
Test.DefaultTestSet("memory", Any[Test Broken
  Skipped: Mem.prefetch(src, nb; device = CUDA.DEVICE_CPU)], 48, false)

@maleadt maleadt added bugfix This gets something working again. cuda libraries Stuff about CUDA library wrappers. labels Jun 3, 2020
@maleadt
Copy link
Member

maleadt commented Jun 3, 2020

bors r+

bors bot added a commit that referenced this pull request Jun 3, 2020
@bors @samo-lin
Merge #197
c170186 
197: [bugfix] Handling of srcPos and dstPos in unsafe_copy3d! r=maleadt a=samo-lin

Closes #27 

Co-authored-by: samo-lin <omlin.samuel@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jun 3, 2020

Build failed:

@maleadt
Copy link
Member

maleadt commented Jun 3, 2020

debug OOM unrelated

@maleadt maleadt changed the title [bugfix] Handling of srcPos and dstPos in unsafe_copy3d! Fix handling of srcPos and dstPos in unsafe_copy3d! Jun 3, 2020
@maleadt maleadt merged commit 7a29a17 into JuliaGPU:master Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix This gets something working again. cuda libraries Stuff about CUDA library wrappers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unsafe_copy3d!: srcPos and dstPos handling
2 participants
@samo-lin @maleadt