Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error throwing tests #207

Merged
merged 1 commit into from
Jun 6, 2020
Merged

Error throwing tests #207

merged 1 commit into from
Jun 6, 2020

Conversation

kshyatt
Copy link
Contributor

@kshyatt kshyatt commented Jun 5, 2020

No description provided.

@kshyatt kshyatt requested a review from maleadt June 5, 2020 14:56
@maleadt maleadt added enhancement New feature or request tests Adds or changes tests. labels Jun 5, 2020
@codecov
Copy link

codecov bot commented Jun 5, 2020

Codecov Report

Merging #207 into master will decrease coverage by 0.36%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
- Coverage   82.30%   81.94%   -0.37%     
==========================================
  Files         143      143              
  Lines        9315     9382      +67     
==========================================
+ Hits         7667     7688      +21     
- Misses       1648     1694      +46     
Impacted Files Coverage Δ
test/cusolver.jl 100.00% <ø> (ø)
test/cusolver/cusparse.jl 95.20% <100.00%> (+0.80%) ⬆️
examples/wmma/high-level.jl 11.11% <0.00%> (-38.89%) ⬇️
examples/wmma/low-level.jl 14.28% <0.00%> (-35.72%) ⬇️
test/device/wmma.jl 0.00% <0.00%> (-7.41%) ⬇️
test/execution.jl 38.68% <0.00%> (-1.47%) ⬇️
test/device/cuda.jl 9.72% <0.00%> (-0.73%) ⬇️
lib/cusolver/wrappers.jl 91.66% <0.00%> (+1.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6666d9...f7388e6. Read the comment docs.

@maleadt maleadt merged commit 29b030c into master Jun 6, 2020
@maleadt maleadt deleted the ksh/solvertests branch June 6, 2020 07:19
@maleadt
Copy link
Member

maleadt commented Jun 6, 2020

It's interesting how coverage doesn't increase by this PR, probably because we include the test folder? That seems useful in its own regard, because we can then spot tests that aren't executed, but may be annoying for the coverage statistics...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tests Adds or changes tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants