Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix finalization of copied arrays. #444

Merged
merged 1 commit into from
Sep 24, 2020
Merged

Fix finalization of copied arrays. #444

merged 1 commit into from
Sep 24, 2020

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Sep 24, 2020

This is already part of https://github.com/JuliaGPU/CUDA.jl/pull/438/files, but I want a separate benchmark run before that PR is merged.

@maleadt maleadt added cuda array Stuff about CuArray. bugfix This gets something working again. labels Sep 24, 2020
@codecov
Copy link

codecov bot commented Sep 24, 2020

Codecov Report

Merging #444 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #444   +/-   ##
=======================================
  Coverage   79.06%   79.06%           
=======================================
  Files         170      170           
  Lines        9275     9277    +2     
=======================================
+ Hits         7333     7335    +2     
  Misses       1942     1942           
Impacted Files Coverage Δ
src/array.jl 87.76% <100.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccccc9a...b263b25. Read the comment docs.

@maleadt maleadt merged commit f9000c2 into master Sep 24, 2020
@maleadt maleadt deleted the tb/fix_copy branch September 24, 2020 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This gets something working again. cuda array Stuff about CuArray.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant