Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dense array types in sparse wrappers. #495

Merged
merged 1 commit into from
Oct 16, 2020
Merged

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Oct 16, 2020

Fixes #493

@maleadt maleadt added the bugfix This gets something working again. label Oct 16, 2020
@codecov
Copy link

codecov bot commented Oct 16, 2020

Codecov Report

Merging #495 into master will increase coverage by 0.01%.
The diff coverage is 29.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #495      +/-   ##
==========================================
+ Coverage   80.52%   80.54%   +0.01%     
==========================================
  Files         166      166              
  Lines        8858     8861       +3     
==========================================
+ Hits         7133     7137       +4     
+ Misses       1725     1724       -1     
Impacted Files Coverage Δ
lib/cusparse/generic.jl 95.40% <ø> (ø)
lib/cusparse/interfaces.jl 33.33% <25.00%> (ø)
test/cusparse.jl 92.29% <66.66%> (-0.15%) ⬇️
lib/cusparse/array.jl 62.64% <0.00%> (+1.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ede842a...c0ba920. Read the comment docs.

@maleadt maleadt merged commit fc690e2 into master Oct 16, 2020
@maleadt maleadt deleted the tb/dense_sparse branch October 16, 2020 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This gets something working again.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sparse matrix * view(vector) regression in 2.0
1 participant