Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use versioned libcuda #502

Merged
merged 1 commit into from
Oct 28, 2020
Merged

Use versioned libcuda #502

merged 1 commit into from
Oct 28, 2020

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Oct 21, 2020

Some systems don't have the libcuda.so.1 -> libcuda.so symlink.

@maleadt maleadt added the installation CUDA is easy to install, right? label Oct 21, 2020
@codecov
Copy link

codecov bot commented Oct 21, 2020

Codecov Report

Merging #502 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #502   +/-   ##
=======================================
  Coverage   80.56%   80.56%           
=======================================
  Files         166      166           
  Lines        8876     8876           
=======================================
  Hits         7151     7151           
  Misses       1725     1725           
Impacted Files Coverage Δ
src/initialization.jl 73.52% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8ca620...7e4d15b. Read the comment docs.

@maleadt
Copy link
Member Author

maleadt commented Oct 22, 2020

Ah, we still support mac, so this will need to be smarter.

@mustafaquraish
Copy link
Contributor

I've only been using julia for a few days, so correct me if I'm completely disregarding any infrastructure around this change, but is it not possible to just throw in a try-catch in the case that libcuda.so is not found and instead try libcuda.so.1? I would assume this only needs to be done once, so would not really have much overhead correct?

(Ofcourse, I guess it's also possible to use Libdl to check if libcuda.so exists)

@maleadt
Copy link
Member Author

maleadt commented Oct 23, 2020

It's possible, but I'd rather just use the correct version. Besides, it would then be embedded in the precompilation image, and not actually performed once each time you load the package, so if the system changes it might still fail.

@maleadt maleadt merged commit 7e4d15b into master Oct 28, 2020
@maleadt maleadt deleted the tb/versioned_libcuda branch October 28, 2020 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installation CUDA is easy to install, right?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants