Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CUTENSOR fixes on Windows #519

Merged
merged 3 commits into from
Oct 30, 2020
Merged

CUTENSOR fixes on Windows #519

merged 3 commits into from
Oct 30, 2020

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Oct 30, 2020

The indices were a legitimate bug. Pinned memory doesn't work, so I just disabled that on Windows for now. @kshyatt any idea why pinned memory + CUTENSOR wouldn't work on Windows?
Probably fixes #422.

@maleadt maleadt added bugfix This gets something working again. cuda libraries Stuff about CUDA library wrappers. labels Oct 30, 2020
@codecov
Copy link

codecov bot commented Oct 30, 2020

Codecov Report

Merging #519 into master will increase coverage by 0.07%.
The diff coverage is 99.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #519      +/-   ##
==========================================
+ Coverage   80.51%   80.58%   +0.07%     
==========================================
  Files         166      166              
  Lines        8889     8911      +22     
==========================================
+ Hits         7157     7181      +24     
+ Misses       1732     1730       -2     
Impacted Files Coverage Δ
lib/cutensor/tensor.jl 83.33% <50.00%> (-8.34%) ⬇️
lib/cutensor/interfaces.jl 100.00% <100.00%> (ø)
lib/cutensor/wrappers.jl 93.90% <100.00%> (+0.09%) ⬆️
test/cutensor/contractions.jl 100.00% <100.00%> (ø)
test/cutensor/elementwise_binary.jl 100.00% <100.00%> (ø)
test/cutensor/elementwise_trinary.jl 97.10% <100.00%> (+0.17%) ⬆️
test/cutensor/permutations.jl 100.00% <100.00%> (ø)
test/cutensor/reductions.jl 100.00% <100.00%> (ø)
src/pool.jl 74.16% <0.00%> (+1.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a14ea2...fdd49f4. Read the comment docs.

@maleadt maleadt merged commit 0c6901b into master Oct 30, 2020
@maleadt maleadt deleted the tb/windows branch October 30, 2020 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This gets something working again. cuda libraries Stuff about CUDA library wrappers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pkg.test error for cutensor test on Windows
1 participant