Use type symbols to generate wrapper methods #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is the test pipeline broken? I would think that this PR is unrelated to CUPTI being unavailable. |
maleadt
force-pushed
the
types-should-be-symbols
branch
from
cf13db4
to
a2a27ac
Compare
|
It was, I fixed it and rebased this PR. |
maleadt
added
bugfix
|
Something is not quite right in the documentation setup even though it worked in #532 |
martenlienen
force-pushed
the
types-should-be-symbols
branch
from
a2a27ac
to
ed579e2
Compare
Codecov Report
@@ Coverage Diff @@
## master #534 +/- ##
=======================================
Coverage 77.83% 77.83%
=======================================
Files 116 116
Lines 6415 6415
=======================================
Hits 4993 4993
Misses 1422 1422
Continue to review full report at Codecov.
|
|
Yes, finally all green :) |
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed these typos in the meta programming code that generates the wrappers for CUSOLVER.