Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong initialisation error message #604

Merged
merged 1 commit into from
Jan 4, 2021

Conversation

qin-yu
Copy link
Contributor

@qin-yu qin-yu commented Dec 23, 2020

Attempt to fix #603

Before fix:

Error: Exception while generating log record in module CUDA at 
/home/qyu/.julia/dev/CUDA/src/initialization.jl:34
│   exception =
│    UndefVarError: ex not defined
│    Stacktrace:
...

After fix:

┌ Error: Recursion during initialization of CUDA.jl
└ @ CUDA ~/.julia/dev/CUDA/src/initialization.jl:38
┌ Error: Error during initialization of CUDA.jl
│   exception =
│    CUDA error (code 999, CUDA_ERROR_UNKNOWN)
│    Stacktrace:
...

@qin-yu
Copy link
Contributor Author

qin-yu commented Dec 23, 2020

Hi @vchuravy @maleadt ! Do you know why "All checks have failed" though I only fixed one line of code 😮

Before fix:
```julia
Error: Exception while generating log record in module CUDA at 
/home/qyu/.julia/dev/CUDA/src/initialization.jl:34
│   exception =
│    UndefVarError: ex not defined
│    Stacktrace:
...
```

After fix:
```julia
┌ Error: Recursion during initialization of CUDA.jl
└ @ CUDA ~/.julia/dev/CUDA/src/initialization.jl:38
┌ Error: Error during initialization of CUDA.jl
│   exception =
│    CUDA error (code 999, CUDA_ERROR_UNKNOWN)
│    Stacktrace:
...
```
@maleadt maleadt added the bugfix This gets something working again. label Jan 4, 2021
@maleadt
Copy link
Member

maleadt commented Jan 4, 2021

Thanks for the fix! Something was wrong with CI, so I fixed that and rebased your PR. Should be good to go then.

@qin-yu
Copy link
Contributor Author

qin-yu commented Jan 4, 2021

Thanks for the fix! Something was wrong with CI, so I fixed that and rebased your PR. Should be good to go then.

Looks like some Error During Test at /root/.julia/packages/GPUArrays/jhRU7/test/testsuite/mapreduce.jl were making the Julia 1.6 (debug) fail (either OOM or illegal assess) in the first run. May I ask what happened? Just out of curiosity.

@codecov
Copy link

codecov bot commented Jan 4, 2021

Codecov Report

Merging #604 (99b24e6) into master (c085721) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #604      +/-   ##
==========================================
+ Coverage   79.95%   79.98%   +0.02%     
==========================================
  Files         116      116              
  Lines        6866     6866              
==========================================
+ Hits         5490     5492       +2     
+ Misses       1376     1374       -2     
Impacted Files Coverage Δ
src/initialization.jl 78.78% <ø> (ø)
lib/cudadrv/stream.jl 89.47% <0.00%> (+2.63%) ⬆️
lib/cudadrv/module.jl 73.33% <0.00%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c085721...99b24e6. Read the comment docs.

@maleadt
Copy link
Member

maleadt commented Jan 4, 2021

I'm not sure what happened, to be honest. I didn't see a sign of OOM, but that often corrupts internal state of libraries which can lead to spurious errors like execution failures. Either way, definitely unrelated to your PR.

@maleadt maleadt merged commit 8f34765 into JuliaGPU:master Jan 4, 2021
@qin-yu qin-yu deleted the qy/fix-init-ex branch January 4, 2021 18:02
maleadt added a commit that referenced this pull request Jan 5, 2021
Fix wrong initialisation error message
maleadt added a commit that referenced this pull request Jan 6, 2021
Fix wrong initialisation error message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This gets something working again.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in Initialisation Error
2 participants