add beta keyword to conv

[jw3126]

No description provided.

[codecov]

Codecov Report

Merging #672 (77ce900) into master (1045963) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #672      +/-   ##
==========================================
- Coverage   77.83%   77.79%   -0.05%     
==========================================
  Files         117      117              
  Lines        7035     7035              
==========================================
- Hits         5476     5473       -3     
- Misses       1559     1562       +3     

Impacted Files	Coverage Δ
lib/cudnn/nnlib.jl	69.42% <100.00%> (ø)
lib/nvml/error.jl	71.42% <0.00%> (-21.43%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1045963...fc0d848. Read the comment docs.

[DhairyaLGandhi]

Thank you for the contribution, thats super helpful!

We do support it in NNlib so that's consistent. We might want to expose this in Flux better though so the implementation matches both cpu and GPU and has consistent APIs to boot.

One comment I would have is that we should retain the default alpha since it makes the code more readable and we might want to test for a couple more cases of using beta with other keyword toggles we can pull

Otherwise lgtm!

[jw3126]

One comment I would have is that we should retain the default alpha since it makes the code more readable and we might want to test for a couple more cases of using beta with other keyword toggles we can pull

done

[DhairyaLGandhi]

Thanks!