Track external globals, use it to avoid needless exception flags #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apparently NVPTX doesn't care about linkage: @exception_flag = internal unnamed_addr externally_initialized global i64 0... so this can work without the Julia PR. Of course, LLVM could do stuff during optimization, but that's unlikely for this global pointer. |
maleadt
added a commit
that referenced
this pull request
Jan 28, 2021
Track external globals, use it to avoid needless exception flags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While thinking about a better design for #552, and making sure external globals now survive (JuliaGPU/GPUCompiler.jl#138, JuliaLang/julia#39387), I figured we need to make it easier to pick those globals up and initialize them.
Probably needs JuliaLang/julia#39387, although we do handle the case where the symbol disappeared here (it's not like we care that the unused global has disappeared, but we should probably restore the linkage to external).